Open
Conversation
Member
Author
|
@mike-tuxedo was sagst du dazu? |
fraxachun
approved these changes
Dec 13, 2018
Contributor
|
statt 'hasContent' -> 'exists': boolean oder 'empty': boolean, der Kontext 'content' ist überflüssig in einer Content API. empty gefällt mir besser weil im client will man nicht immer prüfen ob ein Content da ist ('hasContent'), sondern in wenigen Fällen interessiert mich ob kein Content da ist. In diesen Fällen prüf ich 'empty' auf true. |
|
@rabengraph , deinen Einwand finde ich grundsätzlich richtig. Aber da wir in unseren PHP-Webs hasContent() verwenden, finde ich das einfacher. Einfach weil man das schon kennt und wahrscheinlich als erstes probiert zu verwenden, wenn man wissen will ob Content vorhanden ist. |
mike-tuxedo
approved these changes
Dec 15, 2018
kaufmo
approved these changes
Dec 17, 2018
rabengraph
approved these changes
Dec 17, 2018
Member
Author
|
Mir is beides recht.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #5